Keymaps: Keyboard shortcuts text is too small #7060
Conversation
There was a problem hiding this comment.
I think we need to rethink the column widths better.
For instance, I do not expect that source is cutoff as so when I first open the widget with something like the explorer opened.
Compare this with the implementation present in VS Code:
We should ultimately prioritize:
- that commands and keybindings are displayed entirely when possible
- that the source is displayed properly (should not cutoff the header name)
- that the context (since it is the largest) should be prioritized last
In any case each of these fields can be hovered to display the full content
| } | ||
|
|
||
| .kb table .th-keybinding { | ||
| width: 20%; |
There was a problem hiding this comment.
I'd maybe go 15%-20%, some keybindings are not visible enough.
In general I think that commands and keybindings should be the main priority.
Other columns can have their content shortened and can be fully displayed by hovering over the cells.
For example, look at the following case:
There was a problem hiding this comment.
Update:
- Increased widths for commands and keybindings
- Source is now displayed properly, the way it is done in VSCode
- The context is resized to a smaller size to give more priority to the other two important ones.
Ready for Review.
vince-fugnitto
added
keybindings
Anasshahidd21
force-pushed
the
anas/7051
branch
from
6a66202
to
e578c40
Compare
Issue ID: eclipse-theia#7051 Fixed the sizing of the font, as well as the spacing of each column just so we can utilize the empty spaces in filling up other column's data and still look clean. Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21
force-pushed
the
anas/7051
branch
from
e578c40
to
622bb13
Compare
|
I don't think others are interested in such a change so I'll go ahead and merge :) |
What it does
Issue ID: #7051
Fixed the sizing of the font, as well as the spacing of each column just so we can utilize the empty spaces in filling up other column's data and still look clean.
Signed-off-by: Muhammad Anas Shahid muhammad.shahid@ericsson.com
How to test
Review checklist
Reminder for reviewers