Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filesystem] Fix missing "out of sync error" #7139

Merged
merged 2 commits into from
Feb 18, 2020
Merged

[filesystem] Fix missing "out of sync error" #7139

merged 2 commits into from
Feb 18, 2020

Commits on Feb 18, 2020

  1. fix #7102: missing "out of sync error" 

    which should be shown if one try to save pending editor changes to a file which was modified in background.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
    @akosyakov
    akosyakov committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    e4d8b54 View commit details
    Browse the repository at this point in the history

  2. insulate file resource from failures of file watching 

    Integration tests revealed that nsfw fails from time to time as well as introduce delays. It affects the file resource especially for the delete operation. Instead of relying only on nsfw, file resource now listens to file delete triggered by a user from Theia. It allows to react faster as well as tolerate failures of file watching.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
    @akosyakov
    akosyakov committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    3474d18 View commit details
    Browse the repository at this point in the history