Code snippet: Add support for an array of prefixes #7177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garethwhittaker Could you rebase please? then we can merge it |
Fixes: #7167 Signed-off-by: Gareth Whittaker <garethwhittaker@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #7167
Theia code snippets currently only support a single prefix, whilst VS Code additionally supports an array of prefixes.
This PR brings Theia's support for code snippet prefixes inline with this.
How to test
Try using a snippet with an array of prefixes and ensure these can be utilised.
Check for a regression in snippets with a string prefix.
Review checklist
Reminder for reviewers