Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markers: update tooltip to display full path #7207

Merged
merged 1 commit into from
Feb 25, 2020
Merged

markers: update tooltip to display full path #7207

merged 1 commit into from
Feb 25, 2020

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes #7204

  • updates the MarkerInfoNode (file) tooltip to display the full path of a resource.
  • updates the existing tooltips to instead use the full path.

How to test

  1. start the application with a single-root workspace
  2. create markers and hover over the files in the problems-view
  3. the markers should display the full path when hovering (tooltip)
  4. repeat steps 2 to 3 with a multi-root workspace

Review checklist

Reminder for reviewers

Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto
markers: update tooltip to display full path
6ce9c5a 
Fixes #7204

- updates the `MarkerInfoNode` (file) tooltip to display the full path of a resource.
- updates the existing tooltips to instead use the full path.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves markers issues related to problem markers labels Feb 24, 2020
lmcbout
lmcbout approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on UBUNTU 18.04 with Chrome, Firefox and electron
Tooltip displays the full path for the workspace.
Only one path missing is for the user preference path (Would be nice to have)

@vince-fugnitto vince-fugnitto merged commit c1bd96f into master Feb 25, 2020
@vince-fugnitto vince-fugnitto deleted the vf/GH-7204 branch February 25, 2020 13:04
@vince-fugnitto vince-fugnitto mentioned this pull request Feb 25, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmcbout lmcbout lmcbout approved these changes

Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves markers issues related to problem markers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

markers: update tooltip to display the full path of a resource
2 participants
@vince-fugnitto @lmcbout