Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inline breakpoints #7211

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Fix inline breakpoints #7211

merged 1 commit into from
Feb 27, 2020

Conversation

justin8502
Copy link
Contributor

Issue: #7114

What it does

How to test

  • Open sample file and create a breakpoint without any indentation (on the first column). Run command "Copy Line Down" from Selection Tab or through Find Command.
  • New line should retain breakpoint marker but it will no longer be inline.
  • Breakpoints created with indentation will still have indented breakpoint marker when copied.

Review checklist

Reminder for reviewers

@akosyakov akosyakov added the debug issues that related to debug functionality label Feb 25, 2020
@akosyakov
Copy link
Member

@tom-shan Could you try please?

@justin8502
Fixes: #7114
c89c79f 
- Breakpoints on column 1 do not render red indicator

Signed-off-by: Justin Ang <justinang13@gmail.com>
akosyakov
akosyakov approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! merging if build is green

@justin8502
Copy link
Contributor Author

thank you! merging if build is green

Sure, let me know if there's any issues.

Sorry for having to loop you in so many times.

@akosyakov
Copy link
Member

Sorry for having to loop you in so many times.

it is fine, usually I'm the one who sorry to keep others iterating on PRs 😆

@akosyakov akosyakov merged commit 44a324a into eclipse-theia:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-shan tom-shan tom-shan left review comments

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
debug issues that related to debug functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[debug][ui] Inline breakpoint markers on 0 column
3 participants
@justin8502 @akosyakov @tom-shan