Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display tree node loading on slow connections #7249

Merged
merged 2 commits into from
Mar 2, 2020
Merged

display tree node loading on slow connections #7249

merged 2 commits into from
Mar 2, 2020

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Mar 1, 2020 •
edited
Loading

What it does

  • fix Animating background for tree nodes #3450
    • mark node as busy after 800ms during refreshing
    • new api TreeModel.markAsBusy(node, ms, cancellationToken) to allow clients indicate that some task is performed for the given node (makes visul effect currently only for composite nodes)
  • fix Show progress in Explorer #5959
    • report navigator busy node progress in explorer view container
    • new progress location explorer for the view container

Copied icons were already were approved in previous CQs.

loading

How to test

  • emulate slow connection on the system level, for instance with Network Line Conditioner or Charles2 proxy
  • try to expand some nodes in different trees
    • you should see loading indicator in any tree (i.e. try in npm scripts for the plugin system)
    • you should see blueish bar in the explorer view container for the navigator tree

Review checklist

Reminder for reviewers

@akosyakov akosyakov added navigator issues related to the navigator/explorer tree issues related to the tree (ex: tree widget) labels Mar 1, 2020
@akosyakov
[tree] fix #3450: display node busy state
697a47d 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov force-pushed the akosyakov/animating-background-3450 branch from 5c3b62d to 3b5ff2c Compare March 1, 2020 10:00
@akosyakov akosyakov requested a review from jbicker March 1, 2020 10:09
@akosyakov akosyakov added the progress issues related to the progress functionality label Mar 1, 2020
@akosyakov akosyakov force-pushed the akosyakov/animating-background-3450 branch from 3b5ff2c to d748b70 Compare March 1, 2020 11:04
@AlexTugarev
Copy link
Contributor

@akosyakov just for completeness, could you please state which CQ you refer to?

@akosyakov
Copy link
Member Author

@AlexTugarev #6993 (comment)

AlexTugarev
AlexTugarev reviewed Mar 2, 2020
View reviewed changes
packages/core/src/browser/style/tree.css
padding-right: calc(var(--theia-ui-padding)*2/3);
padding-left: calc(var(--theia-ui-padding)/2);
padding-right: calc(var(--theia-ui-padding)/2);
min-width: var(--theia-icon-size);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

AlexTugarev
AlexTugarev approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, and it works as advertised. Thanks Anton!

@akosyakov
[explorer] fix #5959: report busy progress in view container location
2f8f418 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov force-pushed the akosyakov/animating-background-3450 branch from d748b70 to 2f8f418 Compare March 2, 2020 09:57
@akosyakov akosyakov merged commit e48b9b5 into master Mar 2, 2020
@akosyakov akosyakov deleted the akosyakov/animating-background-3450 branch March 2, 2020 10:45
@westbury westbury mentioned this pull request Oct 2, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

@svenefftinge svenefftinge Awaiting requested review from svenefftinge

@westbury westbury Awaiting requested review from westbury

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy

@vince-fugnitto vince-fugnitto Awaiting requested review from vince-fugnitto

@jbicker jbicker Awaiting requested review from jbicker

@kittaakos kittaakos Awaiting requested review from kittaakos

@spoenemann spoenemann Awaiting requested review from spoenemann

Assignees
No one assigned
Labels
navigator issues related to the navigator/explorer progress issues related to the progress functionality tree issues related to the tree (ex: tree widget)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show progress in Explorer Animating background for tree nodes
2 participants
@akosyakov @AlexTugarev