From 3ccd242e8a1b1c50797ae9af9e56358d77f8efc8 Mon Sep 17 00:00:00 2001 From: Jan Romann Date: Thu, 11 Jan 2024 09:51:00 +0100 Subject: [PATCH] fix(binding-file): improve file-client implementation (#1213) * fix(binding-file): improve file-client implementation * chore(binding-file): improve .gitignore for test files --- packages/binding-file/src/file-client.ts | 12 +++++------- packages/binding-file/test/.gitignore | 3 ++- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/packages/binding-file/src/file-client.ts b/packages/binding-file/src/file-client.ts index cc9b34aa5..47334139d 100644 --- a/packages/binding-file/src/file-client.ts +++ b/packages/binding-file/src/file-client.ts @@ -19,7 +19,7 @@ import { Form, SecurityScheme } from "@node-wot/td-tools"; import { ProtocolClient, Content, createLoggers, ContentSerdes } from "@node-wot/core"; import { Subscription } from "rxjs/Subscription"; -import fs = require("fs"); +import { promises as asyncFs } from "fs"; import { fileURLToPath } from "node:url"; const { debug } = createLoggers("binding-file", "file-client"); @@ -33,8 +33,9 @@ export default class FileClient implements ProtocolClient { const filePath = fileURLToPath(uri); debug(`Reading file of Content-Type ${contentType} from path ${filePath}.`); - const resource = fs.createReadStream(filePath); - return new Content(contentType, resource); + const fileHandle = await asyncFs.open(filePath); + const body = fileHandle.createReadStream(); + return new Content(contentType, body); } public async readResource(form: Form): Promise { @@ -50,10 +51,7 @@ export default class FileClient implements ProtocolClient { public async writeResource(form: Form, content: Content): Promise { const filePath = fileURLToPath(form.href); - const writeStream = fs.createWriteStream(filePath); - const buffer = await content.toBuffer(); - - writeStream.end(buffer); + await asyncFs.writeFile(filePath, content.body); } public async invokeResource(form: Form, content: Content): Promise { diff --git a/packages/binding-file/test/.gitignore b/packages/binding-file/test/.gitignore index eaad84fe9..1ba91c4c8 100644 --- a/packages/binding-file/test/.gitignore +++ b/packages/binding-file/test/.gitignore @@ -1,2 +1,3 @@ # Ignore auxiliary files created by the FileClient implementation tests -test.* +test*.json +test*.txt