Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerated Xtend files #3022

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Regenerated Xtend files #3022

merged 2 commits into from
Apr 30, 2024

Conversation

LorenzoBettini
Copy link
Contributor

After installing the new Xtend in Eclipse I get a few changed files.

While this 341050e comes surely from #2993 (cc @HannesWell) I'm not quite sure about bc51517. Can it be due to #2784? (cc @dvojtise)

@@ -106,8 +106,8 @@ public List<? extends Problem> getProblems(final Element element) {
return this.getProblemSupport().getProblems(element);
}

public void validateLater(final Procedure0 validationCallback) {
this.getProblemSupport().validateLater(validationCallback);
public void validateLater(final Procedure0 arg0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm why does this now toggle back to arg0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, when working on another branch where I'm not yet rebased on master, where #2784 had already been merged, I don't see such changes related to parameter's names; that's why I assume they are due to #2784

Note that in this case, not all parameters are affected.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wired. Let’s recheck after the milestone. I just saw changes the other way round

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve this problem since a while

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szarnekow even before #2784 and when automatic build in Eclipse?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the past we checked in the eclipse built variant and not the maven one but the maven one had the arg0s

@cdietrich that's the eclipse built variant, that's why it's strange. Maybe it's better to revert those two files?

Moreover, only a few parameters miss the proper name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes even in the same file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to affect nested interfaces. maybe something broke in jdt.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szarnekow which class is used to produce the ParameterDeclarations in this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to fix it with #2995

But I only have time to continue that work on Saturday or Sunday this week.

@LorenzoBettini LorenzoBettini merged commit 0afffe3 into main Apr 30, 2024
10 checks passed
@LorenzoBettini LorenzoBettini deleted the lb_xtend_regen branch April 30, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants