-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Che 7: Securing Che #758
Che 7: Securing Che #758
Conversation
Signed-off-by: Michal Maléř <mmaler@redhat.com>
It's ready for SME review @slemeur @l0rd @rkratky @supriya-bharadwaj Can I ask you for a Peer review? |
Signed-off-by: Michal Maléř <mmaler@redhat.com>
eee0f93
to
4f6c2f0
Compare
While those are great description of "how it works", it does not really explain, how an admin must configure Che to run it completely secured. Don't take me wrong, this doc is very helpful and should be merged, but target a different purpose. I think we should rethink this one and move it somewhere else. @rkratky = what would you propose? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichalMaler Don't commit built HTML files to the repo. In this case, assembly_securing-che.html
. Please, remove it.
Signed-off-by: Michal Maléř <mmaler@redhat.com>
@rkratky have you seen my comment? I see that merging. But I don't think the content of the document is going to help an admin to configure Che to be secured. |
Signed-off-by: Michal Maléř mmaler@redhat.com
https://issues.jboss.org/browse/RHDEVDOCS-1149
adding content about Securing Che
rewrote this document into .adoc
https://docs.google.com/document/d/1gvki1dXWtq0Pha4Nv6yAVmuZfVx8U_MIHgv8C59t_3A/edit#