Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che 7: Securing Che #758

Merged
merged 4 commits into from
Jul 28, 2019
Merged

Conversation

MichalMaler
Copy link
Contributor

Signed-off-by: Michal Maléř mmaler@redhat.com

https://issues.jboss.org/browse/RHDEVDOCS-1149

adding content about Securing Che

rewrote this document into .adoc
https://docs.google.com/document/d/1gvki1dXWtq0Pha4Nv6yAVmuZfVx8U_MIHgv8C59t_3A/edit#

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@MichalMaler
Copy link
Contributor Author

It's ready for SME review @slemeur @l0rd

@rkratky @supriya-bharadwaj Can I ask you for a Peer review?

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@slemeur
Copy link
Contributor

slemeur commented Jul 26, 2019

While those are great description of "how it works", it does not really explain, how an admin must configure Che to run it completely secured.

Don't take me wrong, this doc is very helpful and should be merged, but target a different purpose. I think we should rethink this one and move it somewhere else.

@rkratky = what would you propose?

@rkratky rkratky changed the title Securing_Che to .adoc Che 7: Securing Che Jul 27, 2019
@l0rd l0rd mentioned this pull request Jul 27, 2019
85 tasks
Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichalMaler Don't commit built HTML files to the repo. In this case, assembly_securing-che.html. Please, remove it.

MichalMaler and others added 2 commits July 27, 2019 21:17
Signed-off-by: Michal Maléř <mmaler@redhat.com>
@rkratky rkratky merged commit 2aff041 into eclipse-che:master Jul 28, 2019
@slemeur
Copy link
Contributor

slemeur commented Jul 29, 2019

@rkratky have you seen my comment? I see that merging. But I don't think the content of the document is going to help an admin to configure Che to be secured.

@MichalMaler MichalMaler deleted the i1149-Securing_Che branch August 6, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants