This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Fix unhandled exceptions in port-scanner. (eclipse#281) #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monaka
force-pushed
the
pr-fix-unhandled-execption-in-port-scanner
branch
from
b6bc200
to
d251e67
Compare
|
I checked this patch on my environment in Azure AKS. It works fine. |
benoitf
reviewed
Jul 3, 2019
monaka
force-pushed
the
pr-fix-unhandled-execption-in-port-scanner
branch
from
d251e67
to
00e1db4
Compare
monaka
changed the title
|
@benoitf I pushed the patch a749fe2 based on my comment above. |
|
@monaka you're right, no reason to use cat at all and I agree with you on using fs |
monaka
force-pushed
the
pr-fix-unhandled-execption-in-port-scanner
branch
from
00e1db4
to
fb238b7
Compare
monaka
changed the title
|
@benoitf Thanks for your comment. I made new patch using I'm going to test on my Che instance. |
monaka
force-pushed
the
pr-fix-unhandled-execption-in-port-scanner
branch
from
fb238b7
to
476caf4
Compare
|
Can one of the admins verify this PR? |
monaka
force-pushed
the
pr-fix-unhandled-execption-in-port-scanner
branch
from
476caf4
to
d9b5fdf
Compare
Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
monaka
force-pushed
the
pr-fix-unhandled-execption-in-port-scanner
branch
from
d9b5fdf
to
df64477
Compare
Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
monaka
force-pushed
the
pr-fix-unhandled-execption-in-port-scanner
branch
from
df64477
to
1714def
Compare
|
@benoitf I pushed some more fixes here and I believe it becomes reviewable quality. |
evidolob
approved these changes
Jul 11, 2019
|
This PR also should fix eclipse-che/che#13620 |
This was referenced Jul 12, 2019
Closed
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masaki Muranaka monaka@monami-ya.com
What does this PR do?
Fixes a bug in ports-plugin caused on specific K8s clusters.
In case IPv6 was disabled,
/proc/net/tcp6will not exist.(Probably IPv4 will be similar.)
What issues does this PR fix or reference?
eclipse-che/che#13749