Open terminal with non-patched images on OCP 4 fails

[l0rd]

Is your enhancement related to a problem? Please describe.

"CRI-O now has support for adding the entry of the user to the /etc/password if it does not exists in /etc/passwd".

The problem is that it creates an entry like this one on /etc/passwd:

1001360000:x:1001360000:0:1001360000 user:/project:/sbin/nologin

Hence Theia exec plugin uses the login shell /sbin/nologin to open a terminal and fails as described here.

Describe the solution you'd like

When the default login shell is /sbin/nologin use sh instead.

[benoitf]

hello, is that the issue template is no longer working ?

[sunix]

hello, is that the issue template is no longer working ?

I guess you can go bypass with https://github.com/eclipse/che/issues/new

[sunix]

@AndrienkoAleksandr how hard would that be to fix that ? (use /bin/sh instead of /sbin/nologin) ?

[sunix]

@l0rd @rhopp @tsmaeder @slemeur @nickboldt

This has to be 7.0.0 GA:

• We will have many users who will run Che on ocp4
• They will try to go beyond the samples and try their own containers
• This should be an easy fix without to much risk

It would be a shame to loose these users with that bug.

[sunix]

estimation from @AndrienkoAleksandr : 1 day to fix that

[l0rd]

That's a P1 but I have set 7.0.0. That means that @AndrienkoAleksandr should work on it only if he has no blockers assigned.

[AndrienkoAleksandr]

Should be fixed by eclipse-che/che-machine-exec#39