Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "Devfile" on User Dashboard uneditable #22115

Closed
ibuziuk opened this issue Mar 30, 2023 · 14 comments
Closed

Make "Devfile" on User Dashboard uneditable #22115

ibuziuk opened this issue Mar 30, 2023 · 14 comments
Assignees
@ibuziuk
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/next status/validated The issue resolution has been validated team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Milestone
7.65

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Mar 30, 2023 •
edited
Loading

Is your enhancement related to a problem? Please describe

"Devfile" view should be read-only

Describe the solution you'd like

Make "Devfile" on User Dashboard uneditable:
image

Describe alternatives you've considered

N/A

Additional context

Devfile editing UX should happen from workspace, not dashboard - #21606
@ibuziuk ibuziuk added kind/enhancement A feature request - must adhere to the feature request template. area/dashboard sprint/next team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che labels Mar 30, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 30, 2023
@ibuziuk ibuziuk moved this to 📋 Backlog in Eclipse Che Team A Backlog Mar 30, 2023
@ibuziuk ibuziuk moved this from 📋 Backlog to 📅 Planned in Eclipse Che Team A Backlog Mar 30, 2023
@ibuziuk ibuziuk moved this from 📅 Planned to 📋 Backlog in Eclipse Che Team A Backlog Mar 30, 2023
@ibuziuk ibuziuk moved this from 📋 Backlog to 📅 Planned in Eclipse Che Team A Backlog Mar 30, 2023
@ibuziuk ibuziuk moved this from 📅 Planned to 🚧 In Progress in Eclipse Che Team A Backlog Mar 30, 2023
@ibuziuk ibuziuk moved this from 🚧 In Progress to ✅ Done in Eclipse Che Team A Backlog Mar 30, 2023
@ibuziuk ibuziuk moved this from ✅ Done to 🚧 In Progress in Eclipse Che Team A Backlog Mar 30, 2023
@ibuziuk ibuziuk moved this from 🚧 In Progress to 📅 Planned in Eclipse Che Team A Backlog Mar 30, 2023
@ibuziuk ibuziuk moved this from 📅 Planned to 📋 Backlog in Eclipse Che Team A Backlog Mar 30, 2023
@ibuziuk ibuziuk moved this from 📋 Backlog to 📅 Planned in Eclipse Che Team A Backlog Mar 30, 2023
@ibuziuk ibuziuk self-assigned this Mar 30, 2023
@ibuziuk ibuziuk mentioned this issue Mar 31, 2023
Closed
@amisevsk amisevsk added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 31, 2023
@amisevsk
Copy link
Contributor

Setting priority to P1 as there are other issues with the devfile editor -- e.g. it will set the schemaVersion to 2.1.0 and warn about invalid fields that were added in 2.2.0, which can be confusing if you are trying to work on a 2.2.0 devfile.

@tolusha
Copy link
Contributor

tolusha commented Apr 3, 2023

@ibuziuk
I think it is a nice feature to edit devfile after workspace is created.
What do we need to make devfile uneditable?

@ibuziuk
Copy link
Member Author

ibuziuk commented Apr 3, 2023

@tolusha well, this is not how we expect the user to edit the devfile - #21606
basically, the editing is expected to happen in the workspace, not from UD

@ibuziuk ibuziuk removed their assignment Apr 4, 2023
@ibuziuk ibuziuk added this to the 7.65 milestone Apr 5, 2023
@ibuziuk ibuziuk self-assigned this Apr 17, 2023
@ibuziuk ibuziuk mentioned this issue Apr 17, 2023
Merged
@ibuziuk
Copy link
Member Author

ibuziuk commented Apr 18, 2023

PR has been merged, Closing

@ibuziuk ibuziuk closed this as completed Apr 18, 2023
@ibuziuk ibuziuk moved this from 📅 Planned to ✅ Done in Eclipse Che Team A Backlog Apr 18, 2023
@ibuziuk ibuziuk mentioned this issue Apr 19, 2023
Merged
@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Apr 19, 2023 •
edited
Loading

Devfile is still editable in Dashboard using Eclipse Che Next:
Screenshot from 2023-04-19 12-50-13

Dashboard Version: 7.65.0-next

@dmytro-ndp dmytro-ndp reopened this Apr 19, 2023
@dmytro-ndp dmytro-ndp moved this from ✅ Done to 🚧 In Progress in Eclipse Che Team A Backlog Apr 19, 2023
@ibuziuk
Copy link
Member Author

ibuziuk commented Apr 19, 2023

should be fixed by eclipse-che/che-dashboard#783

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Apr 19, 2023 •
edited
Loading

The notice: read-only devfile in Dashboard will make it harder to work with Empty Workspace, which is aimed to simplify custom workspace creation.

@l0rd cc

@ibuziuk
Copy link
Member Author

ibuziuk commented Apr 19, 2023

@dmytro-ndp could you clarify why?

@dmytro-ndp
Copy link
Contributor

Because it's not clear how to change devfile.yaml in empty workspace, which is not pushed to any repos.

@ibuziuk
Copy link
Member Author

ibuziuk commented Apr 19, 2023

empty workspace is meant to be used for cloning the project manually after startup, not for editing devfile from the UD. More details about the devfile editing experience can be found in the epic - #21606

@ibuziuk
Copy link
Member Author

ibuziuk commented Apr 19, 2023

PR has been merged. Closing, feel free to reopen if more clarification is needed

@ibuziuk ibuziuk closed this as completed Apr 19, 2023
@ibuziuk ibuziuk moved this from 🚧 In Progress to ✅ Done in Eclipse Che Team A Backlog Apr 19, 2023
@dmytro-ndp
Copy link
Contributor

@ibuziuk : thanks for explanation.
Hope, users will understate it having the guide about creation of devfile (#18671)

@dmytro-ndp
Copy link
Contributor

Dashboard > workspace > Devfile is read-only on Che dogfooding instance.

Well done, @ibuziuk !

@dmytro-ndp dmytro-ndp moved this from ✅ Done to Verified & Closed in Eclipse Che Team A Backlog Apr 20, 2023
@dmytro-ndp dmytro-ndp added the status/validated The issue resolution has been validated label Apr 20, 2023
@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Apr 20, 2023 •
edited
Loading

@ibuziuk : what do you think about removal of UI elements - Devfile Documentation link, Save / Cancel buttons - which became useless in read-only mode?
useless-ui-elements

@amisevsk amisevsk mentioned this issue May 8, 2023
Merged
3 tasks
@olexii4 olexii4 mentioned this issue May 26, 2023
Closed
@olexii4 olexii4 mentioned this issue Sep 6, 2023
Closed
@l0rd l0rd mentioned this issue Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibuziuk ibuziuk

Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/next status/validated The issue resolution has been validated team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
None yet
Milestone
7.65
Development

No branches or pull requests
5 participants
@dmytro-ndp @ibuziuk @tolusha @amisevsk @che-bot