Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(layered + partitioning) infinite loop with specific set of nodes #993

Open
keyserj opened this issue Jan 14, 2024 · 1 comment
Open

(layered + partitioning) infinite loop with specific set of nodes #993

keyserj opened this issue Jan 14, 2024 · 1 comment
Milestone

Comments

@keyserj
Copy link

keyserj commented Jan 14, 2024

With these settings:

algorithm: layered
partitioning.activate: true
considerModelOrder.strategy: NODES_AND_EDGES

a very specific set of nodes results in an infinite loop, see this reproduction (breaks if you add the commented-out edge - it'll look like it loads with the same layout but if you remove a node or something you'll see that the layout no longer updates based on the configuration, and there's an infinite loading circle).

I tried making a minimal reproduction by removing some nodes, some edges, but this is the smallest reproduction I could make. In the previous issue I made (#969) it was shown that crossingMinimization.greedySwitch.type: OFF avoided the error, and I noticed that works in this case too. But that results in a different layout. Not sure what could be done with this set of configuration - maybe an error could be thrown if the situation arises that will result in an infinite loop?

Note on my node naming: the first letter is the type of node and corresponds to a partition.

@soerendomroes
Copy link
Contributor

This might be a problem with partition and nodes without a partition. I should invesitigate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants