From 0d289f9be19bc2f454ccda1e1d1b5fc30d22e5d0 Mon Sep 17 00:00:00 2001 From: riccardomodanese Date: Tue, 16 Apr 2024 14:42:06 +0200 Subject: [PATCH] :fix: fix metrics names composer and optimize code Signed-off-by: riccardomodanese --- .../commons/metric/MetricsServiceImpl.java | 20 ++----------------- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/commons/src/main/java/org/eclipse/kapua/commons/metric/MetricsServiceImpl.java b/commons/src/main/java/org/eclipse/kapua/commons/metric/MetricsServiceImpl.java index d87cd76ba94..26669ef2f65 100644 --- a/commons/src/main/java/org/eclipse/kapua/commons/metric/MetricsServiceImpl.java +++ b/commons/src/main/java/org/eclipse/kapua/commons/metric/MetricsServiceImpl.java @@ -39,8 +39,6 @@ public class MetricsServiceImpl implements MetricsService { private static final Logger logger = LoggerFactory.getLogger(MetricsServiceImpl.class); - public static final String METRICS_NAME_FORMAT = "{0}.{1}.{2}"; - public static final String METRICS_SHORT_NAME_FORMAT = "{0}.{1}"; private static final char SEPARATOR = '.'; private MetricRegistry metricRegistry; @@ -116,24 +114,10 @@ public void registerGauge(Gauge gauge, String module, String component, Strin } private String getMetricName(String module, String component, String... metricsName) { - return MessageFormat.format(METRICS_NAME_FORMAT, module, component, convertToDotNotation(metricsName)); - } - - /** - * Convert the metric names to a concatenated dot separated string - * - * @param metricsName - * @return - */ - private String convertToDotNotation(String... metricsName) { StringBuilder builder = new StringBuilder(); - boolean firstMetricName = true; + builder.append(module).append(SEPARATOR).append(component); for (String s : metricsName) { - if (!firstMetricName) { - builder.append(SEPARATOR); - } - firstMetricName = false; - builder.append(s); + builder.append(SEPARATOR).append(s); } return builder.toString(); }