From db3e50f773dc89e85ed7a85f85fd002c5e403fc5 Mon Sep 17 00:00:00 2001
From: MDeLuise <66636702+MDeLuise@users.noreply.github.com>
Date: Mon, 9 Sep 2024 16:26:50 +0200
Subject: [PATCH] improve: update PackageDownloadRequest example with optional
 username/password

Updated the default XML string for the PackageDownloadRequest property to include commented-out fields for username and password. This change will help users understand that they can provide credentials for repository access if needed during the package download/install operation. The default setup without credentials remains intact but is now more user-friendly and informative.
---
 .../changelog-packages-job-2.0.0.post.xml     | 22 +++++++++
 ...finition_property_update_example_field.xml | 48 +++++++++++++++++++
 .../changelog-packages-job-master.xml         |  1 +
 3 files changed, 71 insertions(+)
 create mode 100644 service/device/management/packages/job/src/main/resources/liquibase/2.0.0/changelog-packages-job-2.0.0.post.xml
 create mode 100644 service/device/management/packages/job/src/main/resources/liquibase/2.0.0/packages_job_step_definition_property_update_example_field.xml

diff --git a/service/device/management/packages/job/src/main/resources/liquibase/2.0.0/changelog-packages-job-2.0.0.post.xml b/service/device/management/packages/job/src/main/resources/liquibase/2.0.0/changelog-packages-job-2.0.0.post.xml
new file mode 100644
index 00000000000..4270ed78c9c
--- /dev/null
+++ b/service/device/management/packages/job/src/main/resources/liquibase/2.0.0/changelog-packages-job-2.0.0.post.xml
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Copyright (c) 2019, 2022 Eurotech and/or its affiliates and others
+
+    This program and the accompanying materials are made
+    available under the terms of the Eclipse Public License 2.0
+    which is available at https://www.eclipse.org/legal/epl-2.0/
+
+    SPDX-License-Identifier: EPL-2.0
+
+    Contributors:
+        Eurotech - initial API and implementation
+ -->
+<databaseChangeLog
+        xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
+                      http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.0.xsd">
+
+    <include relativeToChangelogFile="true" file="./packages_job_step_definition_property_update_example_field.xml"/>
+
+</databaseChangeLog>
diff --git a/service/device/management/packages/job/src/main/resources/liquibase/2.0.0/packages_job_step_definition_property_update_example_field.xml b/service/device/management/packages/job/src/main/resources/liquibase/2.0.0/packages_job_step_definition_property_update_example_field.xml
new file mode 100644
index 00000000000..d08a8e8025b
--- /dev/null
+++ b/service/device/management/packages/job/src/main/resources/liquibase/2.0.0/packages_job_step_definition_property_update_example_field.xml
@@ -0,0 +1,48 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Copyright (c) 2019, 2022 Eurotech and/or its affiliates and others
+
+    This program and the accompanying materials are made
+    available under the terms of the Eclipse Public License 2.0
+    which is available at https://www.eclipse.org/legal/epl-2.0/
+
+    SPDX-License-Identifier: EPL-2.0
+
+    Contributors:
+        Eurotech - initial API and implementation
+ -->
+<databaseChangeLog
+        xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
+                      http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.0.xsd"
+        logicalFilePath="KapuaDB/packages_job_step_definition_property_update_example_field.xml">
+
+    <include relativeToChangelogFile="true" file="../common-properties.xml" />
+
+    <changeSet id="packages_job_step_definition_property_update-1.2.0" author="eurotech">
+        <update tableName="job_job_step_definition_properties">
+            <column name="example_value" value="&lt;?xml version=&quot;1.0&quot; encoding=&quot;UTF-8&quot;?&gt;&#10;
+&lt;downloadRequest&gt;&#10;
+   &lt;uri&gt;http://download.eclipse.org/kura/releases/3.2.0/org.eclipse.kura.demo.heater_1.0.300.dp&lt;/uri&gt;&#10;
+   &lt;name&gt;heater&lt;/name&gt;&#10;
+   &lt;version&gt;1.0.300&lt;/version&gt;&#10;
+   &lt;install&gt;true&lt;/install&gt;&#10;
+   &lt;!-- &lt;username&gt;&lt;/username&gt;&#10;
+   &lt;password&gt;&lt;/password&gt; --&gt;&#10;
+&lt;/downloadRequest&gt;"/>
+            <where>name = 'packageDownloadRequest'</where>
+        </update>
+
+        <update tableName="job_job_step_definition_properties">
+            <column name="example_value" value="&lt;?xml version=&quot;1.0&quot; encoding=&quot;UTF-8&quot;?&gt;&#10;
+&lt;uninstallRequest&gt;&#10;
+    &lt;name&gt;heater&lt;/name&gt;&#10;
+    &lt;version&gt;1.0.300&lt;/version&gt;&#10;
+    &lt;reboot&gt;true&lt;/reboot&gt;&#10;
+    &lt;rebootDelay&gt;30000&lt;/rebootDelay&gt;&#10;
+&lt;/uninstallRequest&gt;"/>
+            <where>name = 'packageUninstallRequest'</where>
+        </update>
+    </changeSet>
+</databaseChangeLog>
diff --git a/service/device/management/packages/job/src/main/resources/liquibase/changelog-packages-job-master.xml b/service/device/management/packages/job/src/main/resources/liquibase/changelog-packages-job-master.xml
index e8d8654d306..3d28c13b38c 100644
--- a/service/device/management/packages/job/src/main/resources/liquibase/changelog-packages-job-master.xml
+++ b/service/device/management/packages/job/src/main/resources/liquibase/changelog-packages-job-master.xml
@@ -19,5 +19,6 @@
     <include relativeToChangelogFile="true" file="./0.3.0/changelog-packages-job-0.3.0.xml"/>
     <include relativeToChangelogFile="true" file="./1.0.0/changelog-packages-job-1.0.0.xml"/>
     <include relativeToChangelogFile="true" file="./1.0.4/changelog-packages-job-1.0.4.xml"/>
+    <include relativeToChangelogFile="true" file="./2.0.0/changelog-packages-job-2.0.0.post.xml"/>
 
 </databaseChangeLog>