From fca8b82db94b783a3ed264ca30f90b9ee4edcc8a Mon Sep 17 00:00:00 2001 From: Ed Burns Date: Mon, 9 Sep 2024 09:29:47 -0400 Subject: [PATCH] On branch edburns-msft-em-5989-review-2-0 (#232) modified: spec/src/main/asciidoc/metrics.adoc Two trivial changes. - Clarify that conditions are per-attribute. Might not be obvious to someone not deeply familiar with SemConv. - SemConv uses `Opt-In`. I corrected the case. Signed-off-by: Ed Burns --- spec/src/main/asciidoc/metrics.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/src/main/asciidoc/metrics.adoc b/spec/src/main/asciidoc/metrics.adoc index 3876d549..ef311c38 100644 --- a/spec/src/main/asciidoc/metrics.adoc +++ b/spec/src/main/asciidoc/metrics.adoc @@ -78,11 +78,11 @@ The following metrics MUST be provided by runtimes. These are as defined in the All attributes that are listed as required and stable in the OpenTelemetry Semantic Conventions MUST be included. -All attributes that are listed as conditionally required and stable in the OpenTelemetry Semantic Conventions MUST be included when the condition described in the OpenTelemetry Semantic Conventions is satisfied. +All attributes that are listed as conditionally required and stable in the OpenTelemetry Semantic Conventions MUST be included when the per-attribute condition described in the OpenTelemetry Semantic Conventions is satisfied. All attributes that are listed as recommended and stable in the OpenTelemetry Semantic Conventions SHOULD be included if they are readily available and can be efficiently populated. -All attributes that are listed as opt-in and stable in the OpenTelemetry Semantic Conventions MUST NOT be included unless the implementation provides a means for users to configure which opt-in attributes to enable. This requirement is based on OpenTelemetry Semantic Conventions documentation indicating that opt-in attributes MUST NOT be included unless the user has a way to choose if they are enabled/disabled. +All attributes that are listed as Opt-In and stable in the OpenTelemetry Semantic Conventions MUST NOT be included unless the implementation provides a means for users to configure which Opt-In attributes to enable. This requirement is based on OpenTelemetry Semantic Conventions documentation indicating that Opt-In attributes MUST NOT be included unless the user has a way to choose if they are enabled/disabled. Attribute values and usage guidelines as defined in the semantic conventions document MUST be followed. @@ -111,7 +111,7 @@ recommended * `network.protocol.version` -opt-in +Opt-In * `server.address` * `server.port`