Add Connection error callback to fix issue 1148 #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Bolshakov <ivanvaxi@gmail.com>
|
Looks good to me! |
|
Do we want to consider adding this to |
Aposhian
reviewed
Feb 26, 2024
|
I have tested this and confirmed it to work. I created initial support on the C++ client for using this API: https://github.com/fireflyautomatix/paho.mqtt.cpp/tree/connection-error-callback |
Aposhian
approved these changes
Mar 4, 2024
jumoog
approved these changes
Mar 4, 2024
|
I don't think we want to add it to set callbacks, as that would cause some backward incompatibilities which we could manage, but is more complicated. As it is, as it is an interface change, I think it has to go into the 1.4 stream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a callback message with an error connecting to the broker. This message is sent during all connection and reconnection attempts (including automatic reconnection attempts).
This MR solves problems #1148 and #1360
Signed-off-by: Ivan Bolshakov ivanvaxi@gmail.com