add ssl engine function #1512
Open
add ssl engine function #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is anyone here? why the test is always failed, i don't think it's matter with my code. who can help me. 3ks. |
jumoog
reviewed
Aug 15, 2024
| @@ -1076,6 +1076,7 @@ typedef struct | |||
| * 2 means no ssl_error_context, ssl_error_cb | |||
| * 3 means no ssl_psk_cb, ssl_psk_context, disableDefaultTrustStore | |||
| * 4 means no protos, protos_len | |||
| * 5 means no ssl engine | |||
There was a problem hiding this comment.
code format wrong. use TABs
jumoog
reviewed
Aug 15, 2024
jumoog
reviewed
Aug 15, 2024
|
|
||
| /** If not included in the sslKeyStore, this setting points to the file in PEM format containing | ||
| * the client's private key. | ||
| */ | ||
| const char* privateKey; | ||
| const char* privateKey; |
There was a problem hiding this comment.
code format wrong. use TABs
jumoog
reviewed
Aug 15, 2024
|
|
||
| /** The password to load the client's privateKey if encrypted. */ | ||
| const char* privateKeyPassword; | ||
| const char* privateKeyPassword; |
There was a problem hiding this comment.
code format wrong. use TABs
jumoog
reviewed
Aug 15, 2024
| const char* privateKeyPassword; | ||
|
|
||
| /** Key mode Only used if struct_version is >= 6.*/ | ||
| enum MqttSslKeyType keyType; |
There was a problem hiding this comment.
code format wrong. use TABs
jumoog
reviewed
Aug 15, 2024
| enum MqttSslKeyType keyType; | ||
|
|
||
| /** engineId for SSL Only used if struct_version is >= 6.*/ | ||
| const char* engineId; |
There was a problem hiding this comment.
code format wrong. use TABs
You use space but this project uses TABs |
|
hi, glad to meet your answer, a TAB is six space or four space？
…---Original---
From: "Kilian von ***@***.***>
Date: Thu, Aug 15, 2024 21:39 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [eclipse/paho.mqtt.c] add ssl engine function (PR #1512)
My local VSCode shows that the code is aligned, but it is not aligned after submission. what can i do? or you can merge it first?
You use space but this project uses TABs
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, it's me, Im shawshank119. this is my another account, i want to PR the ssl engine function again.
i have fixd the #1247 comments.
My local VSCode shows that the code is aligned, but it is not aligned after submission. what can i do? or you can merge it first?