Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish translation feature #1942

Closed
sdirix opened this issue May 24, 2022 · 0 comments · Fixed by #1944
Closed

Polish translation feature #1942

sdirix opened this issue May 24, 2022 · 0 comments · Fixed by #1944
Assignees
Milestone

Comments

@sdirix
Copy link
Member

sdirix commented May 24, 2022

Is your feature request related to a problem? Please describe.

The i18n keys are currently definable within UI Schema options. This doesn't make much sense as merging in a default config with an i18n key is rarely a desired use case.

Describe the solution you'd like

The i18n key should be placed at the root level of the respective UI Schema element.

Describe alternatives you've considered

None

Framework

Core

RendererSet

Other (please specify in the Additional context field)

Additional context

No response

@sdirix sdirix added this to the 3.0 milestone May 24, 2022
lucas-koehler added a commit to lucas-koehler/jsonforms that referenced this issue May 24, 2022
* The i18n base key can no longer be specified as part of the UI Schema `options`
* Add optional `i18n` property to `ControlElement`
* Adapt i18n key resolution
* Add explicit tests for i18n key extraction from UI Schema and Json Schema

Fix eclipsesource#1942
lucas-koehler added a commit to lucas-koehler/jsonforms that referenced this issue May 27, 2022
* The i18n base key can no longer be specified as part of the UI Schema `options`
* Add optional `i18n` property to `ControlElement`
* Adapt i18n key resolution
* Add explicit tests for i18n key extraction from UI Schema and Json Schema

Fix eclipsesource#1942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants