From 52e11f6660d658286564b88dfdc1b319c35712f5 Mon Sep 17 00:00:00 2001
From: Eugen Neufeld <eneufeld@eclipsesource.com>
Date: Wed, 23 Dec 2020 15:16:40 +0100
Subject: [PATCH] Add manual trigger of changeDetector in Master Renderer

When the data array of the list master detail renderer is empty,
then changing the data does not rerender the ui.
To fix this the changeDetector is manually triggered.
This error can only be reproduced in the seed,
not from the dev environment.
Furthermore the readonly handling was fixed.

Fix #1667
---
 .../angular-material/src/other/master-detail/master.ts   | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/packages/angular-material/src/other/master-detail/master.ts b/packages/angular-material/src/other/master-detail/master.ts
index 34447726e..ee44b283f 100644
--- a/packages/angular-material/src/other/master-detail/master.ts
+++ b/packages/angular-material/src/other/master-detail/master.ts
@@ -24,7 +24,7 @@
 */
 import some from 'lodash/some';
 import get from 'lodash/get';
-import { ChangeDetectionStrategy, Component } from '@angular/core';
+import { ChangeDetectionStrategy, ChangeDetectorRef, Component } from '@angular/core';
 import {
   JsonFormsAngularService,
   JsonFormsArrayControl
@@ -39,7 +39,6 @@ import {
   mapStateToArrayControlProps,
   RankedTester,
   rankWith,
-  setReadonly,
   StatePropsOfArrayControl,
   uiTypeIs
 } from '@jsonforms/core';
@@ -146,7 +145,7 @@ export class MasterListComponent extends JsonFormsArrayControl {
   propsPath: string;
   highlightedIdx: number;
 
-  constructor(jsonformsService: JsonFormsAngularService) {
+  constructor(jsonformsService: JsonFormsAngularService, private changeDetectorRef: ChangeDetectorRef) {
     super(jsonformsService);
   }
 
@@ -179,9 +178,6 @@ export class MasterListComponent extends JsonFormsArrayControl {
         props.path,
         'VerticalLayout'
       );
-    if (!this.isEnabled()) {
-      setReadonly(detailUISchema);
-    }
 
     const masterItems = (data || []).map((d: any, index: number) => {
       const labelRefInstancePath = removeSchemaKeywords(
@@ -229,6 +225,7 @@ export class MasterListComponent extends JsonFormsArrayControl {
       this.selectedItem = this.masterItems[0];
       this.selectedItemIdx = 0;
     }
+    this.changeDetectorRef.markForCheck();
   }
 
   onSelect(item: any, idx: number): void {