React MUI : MaterialEnumArrayRenderer - Add Form Label and description #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ce-enum-label-description
Maxouwell
commented
Feb 27, 2024
lucas-koehler
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Hi @Maxouwell , thanks a lot for another contribution ❤️
The code looks already pretty good to me and showing the labels and description works well in the example :)
I just have two small remarks inline. Please have a look.
packages/material-renderers/src/complex/MaterialEnumArrayRenderer.tsx
Outdated
Show resolved
Hide resolved
packages/material-renderers/src/complex/MaterialEnumArrayRenderer.tsx
Outdated
Show resolved
Hide resolved
lucas-koehler
approved these changes
Mar 1, 2024
Maxouwell
deleted the
feature/mui-react-multi-choice-enum-label-description
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #2296. with always on label (not conditionnal to an option)