diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e1d494cb..96f7f31f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -111,7 +111,7 @@ jobs: runs-on: "ubuntu-latest" strategy: matrix: - php-versions: [ '7.3', '7.4', '8.0', '8.1', '8.2' ] + php-versions: [ '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ] steps: - name: Checkout uses: actions/checkout@v3 @@ -148,6 +148,10 @@ jobs: git clone --depth 1 https://github.com/phpcfdi/resources-sat-xml resources-sat-xml-cloned mv resources-sat-xml-cloned/resources build/resources rm -r -f resources-sat-xml-cloned + - name: Remove genkgo/xsl on PHP 8.3 + if: matrix.php-versions == '8.3' + run: | + composer remove genkgo/xsl --dev --no-interaction --no-progress --no-update - name: Install project dependencies run: | composer remove squizlabs/php_codesniffer friendsofphp/php-cs-fixer phpstan/phpstan --dev --no-interaction --no-progress --no-update @@ -165,7 +169,7 @@ jobs: runs-on: "windows-latest" strategy: matrix: - php-versions: [ '7.3', '7.4', '8.0', '8.1', '8.2' ] + php-versions: [ '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ] steps: - name: Checkout uses: actions/checkout@v3 @@ -196,6 +200,10 @@ jobs: git clone --depth 1 https://github.com/phpcfdi/resources-sat-xml resources-sat-xml-cloned mv resources-sat-xml-cloned/resources build/resources rm -r -f resources-sat-xml-cloned + - name: Remove genkgo/xsl on PHP 8.3 + if: matrix.php-versions == '8.3' + run: | + composer remove genkgo/xsl --dev --no-interaction --no-progress --no-update - name: Install project dependencies run: | composer remove squizlabs/php_codesniffer friendsofphp/php-cs-fixer phpstan/phpstan --dev --no-interaction --no-progress --no-update diff --git a/LICENSE b/LICENSE index cd7a5ab8..26204223 100644 --- a/LICENSE +++ b/LICENSE @@ -1,6 +1,6 @@ The MIT License (MIT) -Copyright (c) 2016 - 2023 Carlos C Soto https://eclipxe.com.mx/ +Copyright (c) 2016 - 2024 Carlos C Soto https://eclipxe.com.mx/ Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal diff --git a/README.md b/README.md index 7dd61bd0..e4ed453e 100644 --- a/README.md +++ b/README.md @@ -68,16 +68,16 @@ This library is compatible with **PHP 7.3 and above**. Please, try to use the la The intended support is to be aligned with the oldest *Active support* PHP Branch. See for more details. -| CfdiUtils | PHP Supported versions | Since | -|-----------|-------------------------|------------| -| 1.0 | 7.0, 7.1 | 2017-09-27 | -| 2.0 | 7.0, 7.1 | 2018-01-01 | -| 2.0.1 | 7.0, 7.1, 7.2 | 2018-01-03 | -| 2.8.1 | 7.0, 7.1, 7.2, 7.3 | 2019-03-05 | -| 2.12.7 | 7.0, 7.1, 7.2, 7.3, 7.4 | 2019-12-04 | -| 2.15.0 | 7.3, 7.4, 8.0 | 2021-03-17 | -| 2.20.1 | 7.3, 7.4, 8.0, 8.1 | 2022-03-08 | -| 2.23.5 | 7.3, 7.4, 8.0, 8.1, 8.2 | 2023-05-26 | +| CfdiUtils | PHP Supported versions | Since | +|-----------|------------------------------|------------| +| 1.0 | 7.0, 7.1 | 2017-09-27 | +| 2.0 | 7.0, 7.1 | 2018-01-01 | +| 2.0.1 | 7.0, 7.1, 7.2 | 2018-01-03 | +| 2.8.1 | 7.0, 7.1, 7.2, 7.3 | 2019-03-05 | +| 2.12.7 | 7.0, 7.1, 7.2, 7.3, 7.4 | 2019-12-04 | +| 2.15.0 | 7.3, 7.4, 8.0 | 2021-03-17 | +| 2.20.1 | 7.3, 7.4, 8.0, 8.1 | 2022-03-08 | +| 2.23.5 | 7.3, 7.4, 8.0, 8.1, 8.2, 8.3 | 2023-05-26 | ## Contributing diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index d933a469..091c2966 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -32,6 +32,13 @@ - Merge methods from `\CfdiUtils\Nodes\NodeHasValueInterface` into `\CfdiUtils\Nodes\NodeInterface`. - Remove deprecated constant `CfdiUtils\Retenciones\Retenciones::RET_NAMESPACE`. +## Unreleased 2024-01-08 + +- Fix continuous integration code style. +- Update license year. Happy 2024! +- Add PHP 8.3 to test matrix on Linux and Windows. +- Remove `genkgo/xsl` on PHP 8.3 since it is not compatible yet. + ## Unreleased 2023-10-30 Fix continuous integration: `php-cs-fixer:3.37.1` fixes. diff --git a/docs/TODO.md b/docs/TODO.md index 4bd4d7cd..7eaf7ecd 100644 --- a/docs/TODO.md +++ b/docs/TODO.md @@ -9,6 +9,11 @@ es necesario agregarla tomando como ejemplo la documentación del *Complemento d ## Verificar problemas conocidos +### Compatibilidad con `genkgo/xsl` + +A la fecha 2023-01-08 la librería `genkgo/xsl` no es compatible con PHP 8.3. +Cuando la dependencia sea compatible, modificar la construcción del proyecto para realizar las pruebas completas. + ### Descarga de certificados desde por certificados vencidos Ver: diff --git a/src/CfdiUtils/Elements/Cfdi33/Helpers/SumasConceptosWriter.php b/src/CfdiUtils/Elements/Cfdi33/Helpers/SumasConceptosWriter.php index eaace921..2103f820 100644 --- a/src/CfdiUtils/Elements/Cfdi33/Helpers/SumasConceptosWriter.php +++ b/src/CfdiUtils/Elements/Cfdi33/Helpers/SumasConceptosWriter.php @@ -8,7 +8,7 @@ /** * @deprecated :3.0.0 - * @see \CfdiUtils\SumasConceptos\SumasConceptosWriter + * @see BaseSumasConceptosWriter */ class SumasConceptosWriter extends BaseSumasConceptosWriter { diff --git a/src/CfdiUtils/Elements/Cfdi40/Helpers/SumasConceptosWriter.php b/src/CfdiUtils/Elements/Cfdi40/Helpers/SumasConceptosWriter.php index e9e5d66f..f8f68633 100644 --- a/src/CfdiUtils/Elements/Cfdi40/Helpers/SumasConceptosWriter.php +++ b/src/CfdiUtils/Elements/Cfdi40/Helpers/SumasConceptosWriter.php @@ -8,7 +8,7 @@ /** * @deprecated :3.0.0 - * @see \CfdiUtils\SumasConceptos\SumasConceptosWriter + * @see BaseSumasConceptosWriter */ class SumasConceptosWriter extends BaseSumasConceptosWriter { diff --git a/src/CfdiUtils/Validate/Cfdi33/Standard/ComprobanteDecimalesMoneda.php b/src/CfdiUtils/Validate/Cfdi33/Standard/ComprobanteDecimalesMoneda.php index a7a64aff..ec5b420c 100644 --- a/src/CfdiUtils/Validate/Cfdi33/Standard/ComprobanteDecimalesMoneda.php +++ b/src/CfdiUtils/Validate/Cfdi33/Standard/ComprobanteDecimalesMoneda.php @@ -24,7 +24,7 @@ class ComprobanteDecimalesMoneda extends AbstractDiscoverableVersion33 /** @var Asserts */ private $asserts; - /** @var \CfdiUtils\Utils\CurrencyDecimals */ + /** @var CurrencyDecimals */ private $currency; private function registerAsserts() diff --git a/src/CfdiUtils/Validate/Cfdi33/Standard/SumasConceptosComprobanteImpuestos.php b/src/CfdiUtils/Validate/Cfdi33/Standard/SumasConceptosComprobanteImpuestos.php index a20c467c..9f4b371c 100644 --- a/src/CfdiUtils/Validate/Cfdi33/Standard/SumasConceptosComprobanteImpuestos.php +++ b/src/CfdiUtils/Validate/Cfdi33/Standard/SumasConceptosComprobanteImpuestos.php @@ -46,7 +46,7 @@ class SumasConceptosComprobanteImpuestos extends AbstractDiscoverableVersion33 /** @var Asserts */ private $asserts; - /** @var \CfdiUtils\SumasConceptos\SumasConceptos */ + /** @var SumasConceptos */ private $sumasConceptos; private function registerAsserts()