Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance 2024-01-08 (Fix build) #115

Merged
merged 4 commits into from
Jan 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
runs-on: "ubuntu-latest"
strategy:
matrix:
php-versions: [ '7.3', '7.4', '8.0', '8.1', '8.2' ]
php-versions: [ '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ]
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down Expand Up @@ -148,6 +148,10 @@ jobs:
git clone --depth 1 https://github.com/phpcfdi/resources-sat-xml resources-sat-xml-cloned
mv resources-sat-xml-cloned/resources build/resources
rm -r -f resources-sat-xml-cloned
- name: Remove genkgo/xsl on PHP 8.3
if: matrix.php-versions == '8.3'
run: |
composer remove genkgo/xsl --dev --no-interaction --no-progress --no-update
- name: Install project dependencies
run: |
composer remove squizlabs/php_codesniffer friendsofphp/php-cs-fixer phpstan/phpstan --dev --no-interaction --no-progress --no-update
Expand All @@ -165,7 +169,7 @@ jobs:
runs-on: "windows-latest"
strategy:
matrix:
php-versions: [ '7.3', '7.4', '8.0', '8.1', '8.2' ]
php-versions: [ '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ]
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down Expand Up @@ -196,6 +200,10 @@ jobs:
git clone --depth 1 https://github.com/phpcfdi/resources-sat-xml resources-sat-xml-cloned
mv resources-sat-xml-cloned/resources build/resources
rm -r -f resources-sat-xml-cloned
- name: Remove genkgo/xsl on PHP 8.3
if: matrix.php-versions == '8.3'
run: |
composer remove genkgo/xsl --dev --no-interaction --no-progress --no-update
- name: Install project dependencies
run: |
composer remove squizlabs/php_codesniffer friendsofphp/php-cs-fixer phpstan/phpstan --dev --no-interaction --no-progress --no-update
Expand Down
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2016 - 2023 Carlos C Soto https://eclipxe.com.mx/
Copyright (c) 2016 - 2024 Carlos C Soto https://eclipxe.com.mx/

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
20 changes: 10 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,16 @@ This library is compatible with **PHP 7.3 and above**. Please, try to use the la
The intended support is to be aligned with the oldest *Active support* PHP Branch.
See <https://www.php.net/supported-versions.php> for more details.

| CfdiUtils | PHP Supported versions | Since |
|-----------|-------------------------|------------|
| 1.0 | 7.0, 7.1 | 2017-09-27 |
| 2.0 | 7.0, 7.1 | 2018-01-01 |
| 2.0.1 | 7.0, 7.1, 7.2 | 2018-01-03 |
| 2.8.1 | 7.0, 7.1, 7.2, 7.3 | 2019-03-05 |
| 2.12.7 | 7.0, 7.1, 7.2, 7.3, 7.4 | 2019-12-04 |
| 2.15.0 | 7.3, 7.4, 8.0 | 2021-03-17 |
| 2.20.1 | 7.3, 7.4, 8.0, 8.1 | 2022-03-08 |
| 2.23.5 | 7.3, 7.4, 8.0, 8.1, 8.2 | 2023-05-26 |
| CfdiUtils | PHP Supported versions | Since |
|-----------|------------------------------|------------|
| 1.0 | 7.0, 7.1 | 2017-09-27 |
| 2.0 | 7.0, 7.1 | 2018-01-01 |
| 2.0.1 | 7.0, 7.1, 7.2 | 2018-01-03 |
| 2.8.1 | 7.0, 7.1, 7.2, 7.3 | 2019-03-05 |
| 2.12.7 | 7.0, 7.1, 7.2, 7.3, 7.4 | 2019-12-04 |
| 2.15.0 | 7.3, 7.4, 8.0 | 2021-03-17 |
| 2.20.1 | 7.3, 7.4, 8.0, 8.1 | 2022-03-08 |
| 2.23.5 | 7.3, 7.4, 8.0, 8.1, 8.2, 8.3 | 2023-05-26 |

## Contributing

Expand Down
7 changes: 7 additions & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@
- Merge methods from `\CfdiUtils\Nodes\NodeHasValueInterface` into `\CfdiUtils\Nodes\NodeInterface`.
- Remove deprecated constant `CfdiUtils\Retenciones\Retenciones::RET_NAMESPACE`.

## Unreleased 2024-01-08

- Fix continuous integration code style.
- Update license year. Happy 2024!
- Add PHP 8.3 to test matrix on Linux and Windows.
- Remove `genkgo/xsl` on PHP 8.3 since it is not compatible yet.

## Unreleased 2023-10-30

Fix continuous integration: `php-cs-fixer:3.37.1` fixes.
Expand Down
5 changes: 5 additions & 0 deletions docs/TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ es necesario agregarla tomando como ejemplo la documentación del *Complemento d

## Verificar problemas conocidos

### Compatibilidad con `genkgo/xsl`

A la fecha 2023-01-08 la librería `genkgo/xsl` no es compatible con PHP 8.3.
Cuando la dependencia sea compatible, modificar la construcción del proyecto para realizar las pruebas completas.

### Descarga de certificados desde <https://rdc.sat.gob.mx/rccf/> por certificados vencidos

Ver: <https://www.phpcfdi.com/sat/problemas-conocidos/descarga-certificados/#problemas-de-caducidad-de-certificados>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

/**
* @deprecated :3.0.0
* @see \CfdiUtils\SumasConceptos\SumasConceptosWriter
* @see BaseSumasConceptosWriter
*/
class SumasConceptosWriter extends BaseSumasConceptosWriter
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

/**
* @deprecated :3.0.0
* @see \CfdiUtils\SumasConceptos\SumasConceptosWriter
* @see BaseSumasConceptosWriter
*/
class SumasConceptosWriter extends BaseSumasConceptosWriter
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class ComprobanteDecimalesMoneda extends AbstractDiscoverableVersion33
/** @var Asserts */
private $asserts;

/** @var \CfdiUtils\Utils\CurrencyDecimals */
/** @var CurrencyDecimals */
private $currency;

private function registerAsserts()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class SumasConceptosComprobanteImpuestos extends AbstractDiscoverableVersion33
/** @var Asserts */
private $asserts;

/** @var \CfdiUtils\SumasConceptos\SumasConceptos */
/** @var SumasConceptos */
private $sumasConceptos;

private function registerAsserts()
Expand Down