feat: 添加 react 代码性能优化转换 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ecomfe/reskript/H2Brsvr2pUSbmKs9ZqhaX3vQsv1Q |
|
解决一下CI问题，应该是少类型定义 |
otakustay
requested changes
Feb 23, 2022
| @@ -59,6 +61,12 @@ export default (options: BabelConfigOptionsFilled): TransformOptions => { | |||
| pluginThrowExpressions, | |||
| pluginDynamicImport, | |||
| pluginImportMeta, | |||
| // https://babeljs.io/docs/en/babel-plugin-transform-react-constant-elements | |||
There was a problem hiding this comment.
这2个插件不应该加在parseOnly里，parseOnly顾名思义是只用来做语法解析的，比如给eslint用。
babel配置一共有3层：
parseOnly：只做解析，不做转换用，给lint、jest等工具transformMinimal：做代码转换，但不做激进的优化，基本只用于skr babel输出transform：全量的优化，代码在index.ts里
所以你需要在那边加这些插件
|
下次提交的时候记得rebase master一下，我把CI修了把，应该更容易跑通了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
参考如下 issue 引入了两个 babel plugin：
用本地项目测了一下，terser 产物的体积会有非常小的增加，不会导致什么实质影响。