What happens when unemployment parameters are None?

[sbenthall]

PR #1112 enforces the presence of unemployment parameters as either floats or lists.

In some older notebooks and maybe other models, these parameters will be None.

What should happen in this case?

[llorracc]

In my view, instead of throwing an exception and halting exection (as now), the code should just allow variables to have a value of None. Possibly a message could be sent to the log (maybe with DEBUG priority) noting that fact.

[sbenthall]

Is an Unemployment probability of None to be interpreted as a probability of 0?

[llorracc]

No, this is a case where there is no retirement period at all so the parameter really has no meaning.

…

On Wed, Feb 23, 2022 at 2:00 PM Sebastian Benthall ***@***.***> wrote: Is an Unemployment probability of None to be interpreted as a probability of 0? — Reply to this email directly, view it on GitHub <#1118 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKCK7ZM5NBX2KUW6MCKT5TU4UVDBANCNFSM5PE6ZL5A> . You are receiving this because you commented.Message ID: ***@***.***>

-- - Chris Carroll

[llorracc]

@Mv77,

I've merged your PR; so I think this issue is ready to be closed?

[Mv77]

HARK's tests passed. However, it is hard to know if the remarks and demarks have been completely fixed. Did the PR resolve the issues in the ones you were working with at least? If so, I'd close the issue.

[llorracc]

I'm running the DemARK tests now. If they pass, I'll close the issue.

…

On Thu, Feb 24, 2022 at 10:23 AM Mateo Velásquez-Giraldo < ***@***.***> wrote: HARK's tests passed. However, it is hard to know if the remarks and demarks have been completely fixed. Did the PR resolve the issues in the ones you were working with at least? If so, I'd close the issue. — Reply to this email directly, view it on GitHub <#1118 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKCK7Y4X6FGO6EXGGGMYWTU4ZEQTANCNFSM5PE6ZL5A> . You are receiving this because you commented.Message ID: ***@***.***>

-- - Chris Carroll

[Mv77]

Did it work?

[llorracc]

I think so; the last automatic test seems to have succeeded. But I'm running one more time just to be sure. PS. Do you have permission to run the tests? It's under the "Actions" button. If not, I'll see if I can add you to those with permission. https://github.com/econ-ark/DemARK/actions/runs/1896008224

…

On Fri, Feb 25, 2022 at 9:56 AM Mateo Velásquez-Giraldo < ***@***.***> wrote: Did it work? — Reply to this email directly, view it on GitHub <#1118 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKCK762M7QR5BMGO5B26ODU46KCFANCNFSM5PE6ZL5A> . You are receiving this because you commented.Message ID: ***@***.***>

-- - Chris Carroll

[Mv77]

I don't.

On a related note, I remember at some point last year you and Seb determined it would be good to make me a "committer" to HARK. I think this would have given me some extra permissions, but it ended up not happening.

[mnwhite]

This issue was resolved.