-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotting graph of equations for FramedAgentType #1071
Conversation
…hildren, graphical plotting
This builds on #1064, which should be merged first. |
Codecov Report
@@ Coverage Diff @@
## master #1071 +/- ##
==========================================
+ Coverage 73.60% 73.64% +0.04%
==========================================
Files 69 69
Lines 10519 10576 +57
==========================================
+ Hits 7742 7789 +47
- Misses 2777 2787 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Is there a way to provide a pseudo-simulation history of shocks that can be used by both agent types? In this way, they both experience the same exact shocks, and differences would be fully attributable to bugs and not to changes in random draws.
That's an excellent idea. I believe there is support for this in the library, but I've never used it: Lines 553 to 556 in a5634ab
Let me try that out before merging. Thanks for the review! |
Ok, I tried copying the shock history over from the first portfolio simulation to the Framed version and using The results were somewhat unexpected:
I may well be using But since that testing is somewhat orthogonal to the plotting work here, I'll merge this PR and address this in a different issue. |
This PR introduces into FramedAgentType the mechanics for frames to reference each other as 'parents' and 'children', including 'back' and 'forward' references when these frames are in a different period.
This enables the plotting of a MACID style network diagram representing the problem, as in the following case (taken from the example notebook):