Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unemp params to be None #1119

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Allow unemp params to be None #1119

merged 2 commits into from
Feb 24, 2022

Conversation

Mv77
Copy link
Contributor

@Mv77 Mv77 commented Feb 24, 2022

My PR #1112 broke some outside functionality (DemARKs and some of @llorracc 's private scripts).

The crux appears to be that UnempPrbRet and related parameters can sometimes be None. This PR edits the income process constructor to accept that.

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@Mv77
Copy link
Contributor Author

Mv77 commented Feb 24, 2022

Does this need a change-log given it is a fix?

@Mv77
Copy link
Contributor Author

Mv77 commented Feb 24, 2022

Allowing it to take integers now too.

Doing this because I assume not taking them might break remarks. I thought those were pinned to specific HARK versions so they would not break. My bad.

@llorracc
Copy link
Collaborator

llorracc commented Feb 24, 2022 via email

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #1119 (bf56f60) into master (413e6d6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1119   +/-   ##
=======================================
  Coverage   73.83%   73.83%           
=======================================
  Files          69       69           
  Lines       10636    10636           
=======================================
  Hits         7853     7853           
  Misses       2783     2783           
Impacted Files Coverage Δ
HARK/ConsumptionSaving/ConsIndShockModel.py 85.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413e6d6...bf56f60. Read the comment docs.

@llorracc llorracc merged commit 38880fa into econ-ark:master Feb 24, 2022
@Mv77 Mv77 deleted the income_process branch December 4, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants