Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Dictionary metric #1260

Merged
merged 3 commits into from
Apr 30, 2023
Merged

Conversation

Mv77
Copy link
Contributor

@Mv77 Mv77 commented Apr 27, 2023

There is a bug in the distance metric for dictionaries.

This PR fixes it and adds a test.

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@Mv77 Mv77 requested a review from alanlujan91 April 27, 2023 20:26
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (39b52bb) 73.20% compared to head (801c57e) 73.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
+ Coverage   73.20%   73.27%   +0.07%     
==========================================
  Files          78       78              
  Lines       12821    12827       +6     
==========================================
+ Hits         9385     9399      +14     
+ Misses       3436     3428       -8     
Impacted Files Coverage Δ
HARK/metric.py 89.58% <100.00%> (+16.66%) ⬆️
HARK/tests/test_core.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@alanlujan91 alanlujan91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@alanlujan91 alanlujan91 merged commit 36960e5 into econ-ark:master Apr 30, 2023
@Mv77 Mv77 deleted the plumbing/metric-fix branch May 1, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants