Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten default initializer dictionaries #1425

Merged
merged 20 commits into from
May 21, 2024
Merged

Commits on May 15, 2024

  1. Clean up ConsIndShockModel dictionaries

    PerfForesight and IndShock dictionaries now stand on their own. KinkedR is still defined from IndShock because it's in the *same file* and is *barely different*. Also changed the spacing / line breaks to better organize the parameters visually.
    mnwhite committed May 15, 2024
    Configuration menu
    Copy the full SHA
    518fa1e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e96fafb View commit details
    Browse the repository at this point in the history
  3. Change test values in fourth digit

    The KinkedR dictionary had an extraneous CubicBool=True in it, for no reason at all. Removing that changed the target test values in the third or fourth digit, so I've adjusted them here.
    mnwhite committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f7deab9 View commit details
    Browse the repository at this point in the history
  4. Fix name

    Of course the one thing I rename for consistency has its own test.
    mnwhite committed May 15, 2024
    Configuration menu
    Copy the full SHA
    9ac688f View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Flattened dictionaries for RiskyAsset and PortfolioModels

    Also partway through ConsBequestModel, will finish on next commit.
    mnwhite committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e9cb4a3 View commit details
    Browse the repository at this point in the history
  2. Finish flattening ConsBequestModel dictionary

    Also fixes an import error in RiskyContribModel.
    mnwhite committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2db83e4 View commit details
    Browse the repository at this point in the history
  3. Flattened LaborModel init dictionary, started on AggShock

    Still need to do the other dictionaries for AggShockModel, but made the main one flat.
    mnwhite committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4fa8a20 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d267fb6 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Flattened dictionaries for GenIncProcessModel

    And turns out there was basically nothing else to do in AggShockModel.
    mnwhite committed May 17, 2024
    Configuration menu
    Copy the full SHA
    a6dfc28 View commit details
    Browse the repository at this point in the history
  2. Fix import in example notebook

    Import same dictionary from different file.
    mnwhite committed May 17, 2024
    Configuration menu
    Copy the full SHA
    eb4c394 View commit details
    Browse the repository at this point in the history
  3. Moved pLvlPctiles to a constructor

    Because pLvlPctiles is now constructed rather than passed raw, the grid changed *very slightly*, so test values changed *very slightly*.
    mnwhite committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6567e1e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b563e5b View commit details
    Browse the repository at this point in the history
  5. MedModel test value needs to adjust as well

    Tiny grid change --> tiny result change.
    mnwhite committed May 17, 2024
    Configuration menu
    Copy the full SHA
    de523f0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d94c7a3 View commit details
    Browse the repository at this point in the history
  7. Flatten dictionary for RepAgent and TBS model

    TBS didn't require any meaningful work, yay.
    mnwhite committed May 17, 2024
    Configuration menu
    Copy the full SHA
    23251ac View commit details
    Browse the repository at this point in the history
  8. Flatten MarkovModel dictionary

    Had to rearrange how the tests are run. This commit will surely break a bunch of examples.
    mnwhite committed May 17, 2024
    Configuration menu
    Copy the full SHA
    46263c4 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Fix Markov tests and examples

    Adjusted base dictionary for one test, changed parameter formatting for the other. In the example notebook, custom built MrkvArray has to be passed to the AgentType instance *after* initialization, because MrkvArray now has a default constructor. This behavior can be improved on later once there's just one call to construct() (and improved dictionaries).
    mnwhite committed May 18, 2024
    Configuration menu
    Copy the full SHA
    eb4275a View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG.md

    mnwhite committed May 18, 2024
    Configuration menu
    Copy the full SHA
    174e1f9 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Configuration menu
    Copy the full SHA
    be344ad View commit details
    Browse the repository at this point in the history
  2. Fix whitespace

    mnwhite committed May 21, 2024
    Configuration menu
    Copy the full SHA
    94ea076 View commit details
    Browse the repository at this point in the history