Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds constructor for LogNormal distribution using mean and std #891

Merged
merged 2 commits into from
Dec 22, 2020

Conversation

sbenthall
Copy link
Contributor

@sbenthall sbenthall commented Dec 22, 2020

fixes #637

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@sbenthall
Copy link
Contributor Author

Could I ask you to please review this @Mv77 ?

It relates to your work on #832 . Reviewing that code reminded me that there was this opportunity to make things a little more brief/direct by adding to the Lognormal distribution class.

@Mv77
Copy link
Contributor

Mv77 commented Dec 22, 2020

Looks great.

Sorry, you had asked me to do it but I was sorting out other things before getting to it.

@sbenthall
Copy link
Contributor Author

No worries it sounded like you had an exam you were working on.

@sbenthall
Copy link
Contributor Author

Because we are short staffed, with @mnwhite on break, I'll take @Mv77 's review as sufficient for acceptance of this PR.

If @mnwhite, @MridulS , or @llorracc have any objections to this policy, let me know; I certainly don't want to overstep.

@sbenthall sbenthall merged commit 435937c into econ-ark:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constructor for lognormal distribution that takes average and variance
2 participants