Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add symfony benchmark #127

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

jlabedo
Copy link
Contributor

@jlabedo jlabedo commented May 29, 2023

No description provided.

*/
public function benchKernelBootAndLoadMessagingSystem()
{
$kernel = new Kernel('test', false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add for prod env too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched to prod environment. Do you really want to have both benchmarks, one for prod and one for test ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for now with prod.

I want to upgrade this to upload the results on each version as artificat and then compare the results with the PR.

@dgafka dgafka merged commit 39b3b5f into ecotoneframework:main May 30, 2023
@dgafka
Copy link
Member

dgafka commented May 30, 2023

Thanks Jean :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants