Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyboard behavior for sui-select is not as framework nor standard html #128

Closed
genuinefafa opened this issue Jun 23, 2017 · 3 comments · Fixed by #132
Closed

keyboard behavior for sui-select is not as framework nor standard html #128

genuinefafa opened this issue Jun 23, 2017 · 3 comments · Fixed by #132
Assignees
@edcarroll
Labels
comp: select priority: low type: bug
Milestone
0.9.0

Comments

@genuinefafa
Copy link

genuinefafa commented Jun 23, 2017 •
edited
Loading

Bug description:

When using <sui-select> up/down arrows of keyboard do not respond to keypress. In the current version it just fallback to browser behavior (move scroll of page in my machine).

The desired behavior, and the one from the framework (and html standard), is to open the select options when downarrow key is pressed on keyboard.

Demo links:

Version of Angular, ng2-semantic-ui, and Semantic UI:

Angular: 4.1.3
ng2-semantic-ui: 0.8.4
Semantic UI: 2.2.10
@genuinefafa genuinefafa changed the title keyboard behavior un sui-select is not as framework nor standard html keyboard behavior for sui-select is not as framework nor standard html Jun 24, 2017
@edcarroll edcarroll self-assigned this Jun 25, 2017
@edcarroll edcarroll added this to the 0.9.0 milestone Jun 25, 2017
@edcarroll
Copy link
Owner

I see the issue, will get a fix for this out in the next release 😄

edcarroll added a commit that referenced this issue Jun 25, 2017
@edcarroll
fix(select): Select now opens on down keypress when focussed
c6bd3e8 
Closes #128
@edcarroll
Copy link
Owner

In a similar vein to this, I've also added full tab support to this branch for the dropdown, search & select components. This means, as in Semantic UI, it is possible to tab between these components (as in tab and shift+tab) and they'll automatically open and close as they gain and lose focus.

@edcarroll edcarroll mentioned this issue Jun 25, 2017
Merged
edcarroll added a commit that referenced this issue Jun 25, 2017
@edcarroll
fix(select): Select now opens on down keypress when focussed
241fa2e 
Closes #128
@edcarroll
Copy link
Owner

This is now live in 0.9.0 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edcarroll edcarroll

Labels
comp: select priority: low type: bug
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

fix(select): Improved keyboard support edcarroll/ng2-semantic-ui
2 participants
@genuinefafa @edcarroll