Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No provider for SuiComponentFactory #160

Closed
mvcoding opened this issue Jul 5, 2017 · 3 comments
Closed

No provider for SuiComponentFactory #160

mvcoding opened this issue Jul 5, 2017 · 3 comments

Comments

@mvcoding
Copy link

mvcoding commented Jul 5, 2017

Bug description:

With v0.9.2 i get an error about a missing provider for SuiComponentFactory when i load just individual modules, specifically SuiSelectModule and using sui-multi-select from it, instead of the full SuiModule. Importing SuiUtilityModule makes the error go away but i'm not sure if it is intended this way.

Link to minimally-working plunker that reproduces the issue:

http://plnkr.co/edit/RiOsIb4uoxAOhW31VX2i?p=preview

Selecting an option throws the error. Import SuiUtilityModule and it goes away.

Version of Angular, ng2-semantic-ui, and Semantic UI:

  • Angular: 4.2.5
  • ng2-semantic-ui: 0.9.2
  • Semantic UI: 2.2.10
@edcarroll
Copy link
Owner

edcarroll commented Jul 5, 2017

Good catch, turns out select & modal were missing the module imports after the project reshuffle in this release.

For now, as you've worked out, adding SuiUtilityModule and SuiLocalizationModule whenever you are importing the SuiSelectModule, and adding SuiUtilityModule whenever you are importing SuiModalModule provides a workaround until this goes into a release.

@edcarroll
Copy link
Owner

Fix for this has been merged, will release in the next couple of days.

@edcarroll
Copy link
Owner

0.9.3 now live with this fix, you can remove references to those extra modules now without any ill effect. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants