Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

834 remove box component #1023

Merged
merged 11 commits into from
Oct 29, 2022
Merged

834 remove box component #1023

merged 11 commits into from
Oct 29, 2022

Conversation

fvives99
Copy link
Contributor

@fvives99 fvives99 commented Oct 27, 2022 •
edited
Loading

What does this PR do?

CheckList

  • Remove Box/Grid Component on remaining components
  • Applied missing styles on remaining components

@fvives99 fvives99 linked an issue Oct 27, 2022 that may be closed by this pull request
Remove Box component #834
Closed
@fvives99 fvives99 self-assigned this Oct 27, 2022
xavier506
xavier506 approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xavier506
xavier506 approved these changes Oct 29, 2022
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 6101781 into dev Oct 29, 2022
@xavier506 xavier506 deleted the 834-remove-box-component branch October 29, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 approved these changes

@tetogomez tetogomez Awaiting requested review from tetogomez

@Torresmorah Torresmorah Awaiting requested review from Torresmorah

Assignees

@fvives99 fvives99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Box component
3 participants
@fvives99 @xavier506 @code-factor