Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/bpjsons load #1081

Merged
merged 8 commits into from
Nov 30, 2022
Merged

Fix/bpjsons load #1081

merged 8 commits into from
Nov 30, 2022

Conversation

Torresmorah
Copy link
Collaborator

Update BP JSON when the object is not empty

What does this PR do?

  • Resolve Missing BP JSONs #1080
  • Avoid overwriting data with an empty BP JSON.
  • Limit loading of BP JSONs to the first 150 producers.

Steps to test

  1. Run the project locally.
  2. Go to block producers page.
  3. Check that the last producer is rank 150.

imagen

@Torresmorah Torresmorah self-assigned this Nov 30, 2022
xavier506
xavier506 approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit ee2472a into dev Nov 30, 2022
@xavier506 xavier506 deleted the fix/bpjsons-load branch November 30, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 approved these changes

@fvives99 fvives99 Awaiting requested review from fvives99

Assignees

@Torresmorah Torresmorah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing BP JSONs
3 participants
@Torresmorah @xavier506 @code-factor