Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webapp): improve error message in Accounts and Contracts page #1138

Merged
merged 1 commit into from
Jan 25, 2023
Merged

feat(webapp): improve error message in Accounts and Contracts page #1138

merged 1 commit into from
Jan 25, 2023

Conversation

Torresmorah
Copy link
Collaborator

Contract Not Showing Up

What does this PR do?

Steps to test

  1. Run the project locally.
  2. Go to the "Accounts and Contracts" page.
  3. Search for account that doesn't exists.
  4. Check the error displayed.
  5. Search for account that exists.
  6. Check the account data.

Screenshots

Show the account data
imagen

The account doesn't exists
imagen

The Endpoints used to request account data didn't respond
imagen

@Torresmorah Torresmorah self-assigned this Jan 25, 2023
maemultichain
maemultichain approved these changes Jan 25, 2023
View reviewed changes
Copy link

@maemultichain maemultichain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, LGTM

xavier506
xavier506 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 23efc1b into dev Jan 25, 2023
@xavier506 xavier506 deleted the fix/improve-accounts-errors-messages-1120 branch January 25, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maemultichain maemultichain maemultichain approved these changes

@xavier506 xavier506 xavier506 approved these changes

Assignees

@Torresmorah Torresmorah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contract Not Showing Up
3 participants
@Torresmorah @xavier506 @maemultichain