Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/improve undiscoverable BPs #1143

Merged
merged 9 commits into from
Jan 30, 2023
Merged

Feat/improve undiscoverable BPs #1143

merged 9 commits into from
Jan 30, 2023

Conversation

Torresmorah
Copy link
Collaborator

@Torresmorah Torresmorah commented Jan 30, 2023 •
edited by maemultichain
Loading

Improve undiscoverable BPs

What does this PR do?

Steps to test

  1. Run the project locally.
  2. Go to "Block Producers" page.
  3. Scroll down until you find an undiscoverable BP.
  4. Click the link "View undiscoverable BPs list".
  5. Check the status of the health check of the websites.
  6. Check the bp.json url.
  7. Click the link "BP JSON Generator".
  8. Check the BP JSON Generator completes the candidate name and website.

Screenshots

Link to undiscoverable BPs from empty state
imagen

Undiscoverable BPs improvements
imagen

Undiscoverable BPs improvements
imagen

Undiscoverable BPs website health check
imagen

Undiscoverable BPs website health check
imagen

Use the right bp.json link instead of the default
imagen

Checklist

  • Follow proper Markdown format
  • The content is adequate
  • The content is available in both english and spanish
  • I Ran a spell check

@Torresmorah
feat(hapi): add health check for website and save bpjson url
4e17310
@Torresmorah
feat(webapp): improve undiscoverable BPs section
23c2e22 
feat(webapp): add url health check
feat(webapp): add link to BP json and BP json Generator
feat(webapp): add link to undiscoverable BPs section
@Torresmorah
feat(hasura): add bp_json_url to producer table
90ea00a
@Torresmorah
feat(hapi): save bp_json_url
9200bd7
@Torresmorah
feat(webapp): improve undiscoverable BPs page
0594a8d 
refactor: Move and rename EndpointInfo to HealthCheck
feat: query bp_json_url in the PRODUCER_QUERY
fix: remove zoomableGroup from the map of Rewards Distribution
@Torresmorah
fix(webapp): use right bp.json url and fix styles
98f4f40
@Torresmorah
fix(hapi): fix health_status and refactor unneeded commentary
b89f446
@Torresmorah Torresmorah added the WIP Work In Progress label Jan 30, 2023
@Torresmorah Torresmorah self-assigned this Jan 30, 2023
@Torresmorah Torresmorah removed the WIP Work In Progress label Jan 30, 2023
maemultichain
maemultichain approved these changes Jan 30, 2023
View reviewed changes
Copy link

@maemultichain maemultichain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool, LGTM

xavier506
xavier506 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 59c2f01 into dev Jan 30, 2023
@xavier506 xavier506 deleted the feat/improve-undiscoverable-BPs branch January 30, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maemultichain maemultichain maemultichain approved these changes

@xavier506 xavier506 xavier506 approved these changes

@Edwinjrc Edwinjrc Awaiting requested review from Edwinjrc

Assignees

@Torresmorah Torresmorah

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Torresmorah @xavier506 @maemultichain