Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/missed blocks not working 1208 #1248

Merged
merged 14 commits into from
Jul 27, 2023
Merged

Fix/missed blocks not working 1208 #1248

merged 14 commits into from
Jul 27, 2023

Conversation

Torresmorah
Copy link
Collaborator

Fix missed blocks page

What does this PR do?

  • Resolve Missed blocks not working on libre testnet #1208
  • Use the chain api to get the current schedule instead of check every action with the demux pattern
  • Start the missed blocks calculation with the first available schedule in the DB
  • Improve the subscriptions in the frontend related with the stats to avoid listen changes of unused data

Steps to test

  1. Run the project locally
  2. Go to missed blocks page
  3. Check the results

Screenshot

imagen
imagen

@Torresmorah
fix(hapi): fix missed blocks
8aea632 
- obtain the current schedule through the chain API
- calculate missing blocks with available schedules
@Torresmorah
fix(hapi): fix the update of the last_block_at in the stats
1c64129
@Torresmorah
fix(webapp): fix missed blocks
50ebe6d
@Torresmorah
fix(hapi): use first schedule to sycn missed blocks per bp
a14c9d4
@Torresmorah
perf(webapp): split the subscription to the stats table to avoid requ…
e8d0068 
…esting more data than needed
@Torresmorah
chore(hasura): add missed_block_checked_at to stats table
9efc248
@Torresmorah
chore(hapi): use missed_block_checked_at to avoid to updating frequen…
05fbe07 
…tly the missed_block field
@Torresmorah
chore(hasura): remove unused fields in the round_history and schedule…
7aeec80 
…_history tables
@Torresmorah
chore(hapi): calculate scheduled and produced blocks using the amount…
0b73c0e 
… of rows
@Torresmorah
fix(hapi): waits last round to get current missed blocks and delete o…
5b9a328 
…ld rounds
@Torresmorah
fix(webapp): remove unused logic to display missed blocks
4d7111d
@Torresmorah
feat(workflows): enable missed blocks in libre testnet
32eca15
@Torresmorah Torresmorah self-assigned this Jul 26, 2023
xavier506
xavier506 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 8d58d86 into dev Jul 27, 2023
@xavier506 xavier506 deleted the fix/missed-blocks-not-working-1208 branch July 27, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 approved these changes

Assignees

@Torresmorah Torresmorah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missed blocks not working on libre testnet
3 participants
@Torresmorah @xavier506 @code-factor