Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webapp): correct card dimensions for mobile #958

Merged
merged 2 commits into from
Oct 12, 2022
Merged

fix(webapp): correct card dimensions for mobile #958

merged 2 commits into from
Oct 12, 2022

Conversation

fvives99
Copy link
Contributor

@fvives99 fvives99 commented Oct 10, 2022 •
edited
Loading

What does this PR do?

Steps to test

  1. Navigate to Rewards distribution and see mobile view

CheckList

  • Fixed card showing outside the screen on mobile, now showing vertically
  • added homepage matching shadows for Cards, Map and Popover

@fvives99 fvives99 linked an issue Oct 10, 2022 that may be closed by this pull request
fix mobile view for rewards distribution #956
Closed
@fvives99
Copy link
Contributor Author

Before:
image
After:
image

@fvives99 fvives99 self-assigned this Oct 10, 2022
Torresmorah
Torresmorah approved these changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@Torresmorah Torresmorah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xavier506
xavier506 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit f9d6b90 into dev Oct 12, 2022
@xavier506 xavier506 deleted the 956-fix-mobile-view-for-rewards-distribution branch October 12, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torresmorah Torresmorah Torresmorah approved these changes

@xavier506 xavier506 xavier506 approved these changes

@tetogomez tetogomez Awaiting requested review from tetogomez

Assignees

@fvives99 fvives99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix mobile view for rewards distribution
4 participants
@fvives99 @xavier506 @Torresmorah @code-factor