Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use bytes32 for metadataHash #92

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Oct 13, 2023

No description provided.

@tmigone tmigone requested a review from Theodus October 13, 2023 18:24
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone tmigone force-pushed the tmigone/hash-bytes32 branch from 95a4e3c to 473be65 Compare October 13, 2023 18:26
@tmigone tmigone changed the base branch from main to tmigone/deploy-registry-arbgoerli October 13, 2023 18:26
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Theodus
Copy link
Member

Theodus commented Oct 23, 2023

@tmigone shall we merge this?

@tmigone tmigone merged commit 748b24d into tmigone/deploy-registry-arbgoerli Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants