Enclave signing #199
Open
Enclave signing #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyakubovich
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Thank you for your contribution! It's something that has been on our mind so great to see it make its way in.
A concern with signing long lived artifacts is that it pushes one to use long lived certs. Unfortunately there's no revocation mechanism so one should be careful.
Just a few changes and I think it'll be good to merge.
| cmd.push("/var/run/key"); | ||
|
|
||
| let certificate_path = canonicalize(PathBuf::from(manifest_path).parent().unwrap().join(&signature.certificate)).await?; | ||
| let key_path = canonicalize(PathBuf::from(manifest_path).parent().unwrap().join(&signature.key)).await?; |
There was a problem hiding this comment.
I would move these two lines to the caller and just path the paths for the cert and key into the function.
| cmd.push("--private-key"); | ||
| cmd.push("/var/run/key"); | ||
|
|
||
| let certificate_path = canonicalize(PathBuf::from(manifest_path).parent().unwrap().join(&signature.certificate)).await?; |
There was a problem hiding this comment.
Use .parent()? instead to avoid panicking if someone passes in a bad path.
| #[serde(deny_unknown_fields)] | ||
| pub struct Signature { | ||
| pub certificate: String, | ||
| pub key: String, |
There was a problem hiding this comment.
Make these PathBuf to be clear that they're paths and also avoid conversions later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning!!! I am less than a n00b in rust, this was done to scratch my own itch and it worked for me.