Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Dockerfile template, with images from hex.pm #223

Merged

Conversation

bettio
Copy link
Contributor

@bettio bettio commented Oct 20, 2022

This template is based on the Dockerfile that nowadays is generated with mix phx.gen.release, and make use of tagged images with well known versions, rather a rolling tag.
Elixir and OTP version are explicitly set, and should be manually updated.

Signed-off-by: Davide Bettio davide.bettio@secomind.com

@bettio bettio requested a review from rbino October 20, 2022 16:50
@coveralls
Copy link

coveralls commented Oct 20, 2022

Pull Request Test Coverage Report for Build 78ec77ff978dec623ace039759fe2d94ef659eec-PR-223

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.235%

Totals Coverage Status
Change from base Build 1777f7126bde0c936802c6f1da5f1fa6cbda6d05: 0.0%
Covered Lines: 1148
Relevant Lines: 1396

💛 - Coveralls

backend/Dockerfile Show resolved Hide resolved
@bettio bettio added this to the v0.7 milestone Jun 22, 2023
@bettio bettio added the chore Maintenance chore label Jun 22, 2023
@bettio bettio force-pushed the use-new-dockerfile-template branch 9 times, most recently from 9fdae68 to 545e3d5 Compare July 12, 2023 16:40
This template is based on the Dockerfile that nowadays is generated with
mix phx.gen.release, and make use of tagged images with well known
versions, rather a rolling tag.
Elixir and OTP version are explicitly set, and should be manually
updated.

Signed-off-by: Davide Bettio <davide.bettio@secomind.com>
@bettio bettio force-pushed the use-new-dockerfile-template branch from 545e3d5 to 78ec77f Compare July 12, 2023 16:42
@szakhlypa szakhlypa merged commit 0f12af4 into edgehog-device-manager:main Jul 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance chore
Projects
Development

Successfully merging this pull request may close these issues.

5 participants