refactor: unify preload_defaults functions
#316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 894d4e38192a06b731613d1fae22a141bbb47b72-PR-316
💛 - Coveralls |
noaccOS
force-pushed
the
default-preload-behavior
branch
6 times, most recently
from
bb375d2
to
a58425f
Compare
they work like get functions but always return a tuple {:ok, item} or
{:error, :not_found}
Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
Provide a global `Repo.preload_defaults` to load default preloads for a given module, instead of using a distinct function for each one. `Repo.preload_defaults`'s logic is to make modules define their own `default_preloads/0` function, and use its return value as `Repo.preload/3`'s second parameter. `Repo.preload_defaults_in_result` is provided for ease of use after a fetch/update/insert method. Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
noaccOS
force-pushed
the
default-preload-behavior
branch
from
a58425f
to
c4c107b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a global
Repo.preload_defaultsto load default preloads for a given module, instead of using a distinct function for each one.Repo.preload_defaults's logic is to make modules define their owndefault_preloads/0function, and use its return value asRepo.preload/3's second parameter.A follow up pr might define a behaviour for the
default_preloads/0function, but this might reside in an external library and it is unclear to me whether it provides significant advantages.Edit: now depends on #322
Edit:
Repo.preload_defaults_in_resultis provided for ease of use aftera fetch/update/insert method.