executor_test: make expectations order-independent #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version was causing flakyness in tests since it assumed a specific order for the devices, which is not guaranteed. The new version removes that assumption. The presence of each and every target device is verified by the `send_sync` mechanism anyway. Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
Pull Request Test Coverage Report for Build 4149660ba9039076c0bb854090632f30550b870e-PR-569Details
💛 - Coveralls |
davidebriani
approved these changes
Jul 8, 2024
Pavinati
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version was causing flakyness in tests since it assumed a specific order for the devices, which is not guaranteed. The new version removes that assumption. The presence of each and every target device is verified by the
send_syncmechanism anyway.