Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying accepted avisories for SWHardeningNeeded TCB status #733

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

daniel-weisse
Copy link
Member

#729 added support for reading the Security Advisories if attestation failed due to invalid TCB status.
This PR builds on that to allow users to specify just specific advisories when the reported TCB status is SWHardeningNeeded

Proposed changes

  • Add a new flag to the CLI --accepted-advisories which allows specifying a list of Intel Security Advisories to accept if the Coordinator's TCB status is SWHardeningNeeded. If not set, all advisories are accepted
  • Add a new manifest field Packages.AcceptedAdvisories which allows specifying a list of Intel Security Advisories to accept if the package's TCB status is SWHardeningNeeded. If not set, all advisories are accepted
  • Fix for the CLI printing a nil error if parsing the advisory list of a report failed

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for marblerun-docs canceled.

Name Link
🔨 Latest commit 69323e6
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/66fce6f49ad8ca00087b32e4

api/attestation/attestation.go Outdated Show resolved Hide resolved
api/attestation/attestation.go Outdated Show resolved Hide resolved
coordinator/quote/ert.go Show resolved Hide resolved
internal/tcb/tcb_test.go Show resolved Hide resolved
coordinator/quote/ert.go Show resolved Hide resolved
api/attestation/attestation_test.go Show resolved Hide resolved
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse merged commit bc05f54 into master Oct 2, 2024
9 of 10 checks passed
@daniel-weisse daniel-weisse deleted the dw/advisory-whitelist branch October 2, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants