fix: remove unit tests related to redis pub/sub #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per edgexfoundry/go-mod-messaging#366, EdgeX remove support on Redis Pub/Sub as message bus, so unit tests related to redis pub/sub should be removed as well to avoid errors. Notr that redis pub/sub doesn't need to establish preemptive connection before publish and subscribe, and a redis client can be susccessfully created and make noop Connect() without error per the implmentation of removed unit tests. Signed-off-by: Jude Hung <jude@iotechsys.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
==========================================
- Coverage 46.77% 46.31% -0.46%
==========================================
Files 58 58
Lines 3519 3519
==========================================
- Hits 1646 1630 -16
- Misses 1753 1770 +17
+ Partials 120 119 -1 ☔ View full report in Codecov by Sentry. |
cloudxxx8
requested changes
Nov 7, 2024
|
please squash the commits or rename the commit with prefix |
judehung
force-pushed
the
remove-redis-pubsub
branch
from
7c53198
to
9afcd9e
Compare
Signed-off-by: Jude Hung <jude@iotechsys.com>
judehung
force-pushed
the
remove-redis-pubsub
branch
from
9afcd9e
to
1aa78c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per edgexfoundry/go-mod-messaging#366, EdgeX remove support on Redis Pub/Sub as message bus, so unit tests related to redis pub/sub should be removed as well to avoid errors.
Note that redis pub/sub doesn't need to establish preemptive connection before publish and subscribe, and a redis client can be susccessfully created and make noop Connect() without error per the implmentation of removed unit tests.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)