Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unit tests related to redis pub/sub #793

Merged
merged 2 commits into from
Nov 7, 2024
Merged

fix: remove unit tests related to redis pub/sub #793

merged 2 commits into from
Nov 7, 2024

Commits on Nov 7, 2024

  1. fix: remove unit tests related to redis pub/sub 

    Per edgexfoundry/go-mod-messaging#366,
EdgeX remove support on Redis Pub/Sub as message bus, so unit tests
related to redis pub/sub should be removed as well to avoid errors.

Notr that redis pub/sub doesn't need to establish preemptive connection
before publish and subscribe, and a redis client can be susccessfully
created and make noop Connect() without error per the implmentation of
removed unit tests.

Signed-off-by: Jude Hung <jude@iotechsys.com>
    @judehung
    judehung committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c09c5df View commit details
    Browse the repository at this point in the history

  2. fix: Update the secretName from redis to other meaningful naming 

    Signed-off-by: Jude Hung <jude@iotechsys.com>
    @judehung
    judehung committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1aa78c2 View commit details
    Browse the repository at this point in the history