Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue not convert   to space in data items fix #41 #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AbrahemAlhofe
Copy link

@AbrahemAlhofe AbrahemAlhofe commented Jul 22, 2020

get data was get inner html of list items and replace
elements to space but there is other browsers like chrome convert spaces in the end of text to   so it was important to replace   to space

Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, attach an issue describing a problem you resolve

@AbrahemAlhofe
Copy link
Author

i have been added yet

@neSpecc
Copy link
Contributor

neSpecc commented Aug 1, 2020

There is still no attached issue

@AbrahemAlhofe
Copy link
Author

Do you mean in commit message i did not put "close #issue number" ya.?

@neSpecc
Copy link
Contributor

neSpecc commented Aug 1, 2020

Do you mean in commit message i did not put "close #issue number" ya.?

yes, you can add it to the PR's description

@AbrahemAlhofe AbrahemAlhofe changed the title fix issue not convert   to space in data items fix issue not convert   to space in data items fix #41 Aug 1, 2020
@AbrahemAlhofe
Copy link
Author

That is okay

@ranemihir
Copy link

@AbrahemAlhofe can u provide some description about the PR? What kind of issue are you trying to solve with this PR?

@Paget96
Copy link

Paget96 commented Aug 20, 2023

This issue still persist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants