Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[may not be needed, see issue details] Advanced preference for "migrate item id from archiveLocation to extra:EdTechHub.ItemAlsoKnownAs" #35

Closed
bjohas opened this issue Feb 25, 2020 · 4 comments

Comments

@bjohas
Copy link
Collaborator

bjohas commented Feb 25, 2020

I wonder whether the implementation of hidden preferences is easy?

I think it would be good to have a the function for migration #27 as a hidden preference, with default = false

AdvancedPreference.migrateArchiveLocationToExtraETHItemAlsoKnownAs = false

I would then enable this in my Zotero, and do the migration. That should help with not accidentally migrating things that should be in archiveLocation. Also, we then don't have to remove the code later, but I can just turn it off.

@bjohas bjohas changed the title Advanced preference for "migrate item id from archiveLocation to extra:ETHItemAlsoKnownAs" Advanced preference for "migrate item id from archiveLocation to extra:EdTechHub.ItemAlsoKnownAs" Apr 12, 2020
@retorquere
Copy link
Collaborator

Hidden prefs are easy. but if #27 is only ran manually, what would be the benefit of having this preference?

@bjohas
Copy link
Collaborator Author

bjohas commented Apr 12, 2020

The benefit is an extra safety layer. I would expect that I do all the conversion myself (for all our libraries) and that probably there aren't any other users of the plugin yet. So the conversion is a one-off process (manually initiated by 'ETH save item ID'). I would not want it to be generally available as it may mess tings up in the long term

@bjohas
Copy link
Collaborator Author

bjohas commented Apr 13, 2020

We had discussed that this is a one-off migration issue. @retorquere had suggested that this could be done with a custom script more easily?

If that's the case, then we don't need this preference, c.f. #27

@bjohas bjohas changed the title Advanced preference for "migrate item id from archiveLocation to extra:EdTechHub.ItemAlsoKnownAs" [may not be needed, see issue details] Advanced preference for "migrate item id from archiveLocation to extra:EdTechHub.ItemAlsoKnownAs" Apr 13, 2020
@retorquere
Copy link
Collaborator

That's what I'm working on now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants