From cf3ebf119d4cdf3e87e7e9e460cf0bf08c3a393f Mon Sep 17 00:00:00 2001 From: Delyan Raychev Date: Wed, 6 Jan 2021 10:29:58 -0800 Subject: [PATCH] eds: Remove unused variables and inline usage of meshCatalog.ListAllowedOutboundServicesForIdentity() in for loop (#2259) Signed-off-by: Delyan Raychev --- pkg/envoy/eds/response.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/pkg/envoy/eds/response.go b/pkg/envoy/eds/response.go index ce18128f90..412c4e36e7 100644 --- a/pkg/envoy/eds/response.go +++ b/pkg/envoy/eds/response.go @@ -30,14 +30,9 @@ func NewResponse(meshCatalog catalog.MeshCataloger, proxy *envoy.Proxy, _ *xds_d log.Error().Err(err).Msgf("Error looking up proxy identity for proxy with CN=%q", proxy.GetCommonName()) return nil, err } - outboundServices := meshCatalog.ListAllowedOutboundServicesForIdentity(proxyIdentity) - if err != nil { - log.Error().Err(err).Msgf("Error listing outbound services for proxy %q", proxyServiceName) - return nil, err - } outboundServicesEndpoints := make(map[service.MeshService][]endpoint.Endpoint) - for _, dstSvc := range outboundServices { + for _, dstSvc := range meshCatalog.ListAllowedOutboundServicesForIdentity(proxyIdentity) { endpoints, err := meshCatalog.ListEndpointsForService(dstSvc) if err != nil { log.Error().Err(err).Msgf("Failed listing endpoints for service %s", dstSvc)